router.js

router.js copied to clipboard

The Transition object already mimics a thenable via then but lacks catch and finally etc, why not just make it a subclass

https://github.com/tildeio/router.js/blob/master/lib/router/transition.js

Resolved in https://github.com/tildeio/router.js/commit/83f33bad29472ec03a973117e23c52b241fa1440

@jmeas no, that doesn't resolve it. That merely creates a promise like entity that decorates a rail promise, it does not create a subclass.

Ah, gotcha :+1:

I'm doing some issues-gardening 🍀 🌷 and stumbled upon this. Is this still an issue? if not, perhaps it can be closed?

Yes, it is still an issue.