furnace icon indicating copy to clipboard operation
furnace copied to clipboard

Published 20 hours ago • verified publisher icon tildearrow

Legacy DM DMPs don't work (YM2612)

Open freq-mod opened this issue 3 years ago • 12 comments

Demo Presets.zip - at least just these, made 0.12.0 iirc

freq-mod avatar Jan 31 '22 08:01 freq-mod

I have tested demo instruments shipped with Legacy Deflemask. Only YM2151, Game Boy and C64 instruments work correctly. Genesis instuments... are somewhat broken. Examples: genbugs.zip Assuming they even load, they are imported as "standard", with waveform macro on with length of 1 and value of 251893009 :joy:

freq-mod avatar Jan 31 '22 13:01 freq-mod

Please try loading a legacy instrument using git master. I've added some code to handle them, albeit not complete.

tildearrow avatar Jan 31 '22 18:01 tildearrow

Instruments that refused the load still refuse to load, instrument that were completely broken... well no longer have glitched up macros, but only the algorithms and feedback is loaded, the rest of the instrument is from the default one

freq-mod avatar Jan 31 '22 19:01 freq-mod

Loading fixed... erm... partially.... for 0.5.1. SMS, NES, FM and other instruments load properly now (apparently). This format really is a mess to work with.

I would like feedback.

Edit: for some reason it also recognizes GB and C64 instruments? to some extent...

tildearrow avatar Feb 01 '22 05:02 tildearrow

Seems like it's working... I will test more though

freq-mod avatar Feb 01 '22 08:02 freq-mod

Edit: for some reason it also recognizes GB and C64 instruments? to some extent...

These also work fine and I had no issue with instruments getting misidentified

freq-mod avatar Feb 01 '22 08:02 freq-mod

It's like the only downside is the warning (I think these 22 bytes can be ignored). They seem like 0.12.0 instruments

I tested most of instruments I had, no probs

freq-mod avatar Feb 01 '22 09:02 freq-mod

Will mark as done then (for now).

tildearrow avatar Feb 02 '22 09:02 tildearrow

Furnace is still loading Legacy DefleMask .dmps' parameters incorrectly. The zip file contains comparisons between the original .dmp and the resulting .fui, which is oddly different. It seems like operators 2 and 4's parameters are the ones not being loaded properly. GENESIS.zip

It also still has that warning of "More data at the end of the file, 22 bytes".

brickblock369 avatar Feb 24 '22 20:02 brickblock369

Hmm, so it seems like the DefleMask instruments from DefleMask Legacy's repo specifically are the ones having a problem. Other instruments I saved on my own with DefleMask Legacy work fine...

brickblock369 avatar Mar 07 '22 19:03 brickblock369

@brickblock369 as of the 82ae2bf your legacy .dmp load and work fine, same for all 0.12 demo instruments. Do you have or can find any .dmps that don't work?

freq-mod avatar Apr 03 '22 07:04 freq-mod

Situations which Furnace doesn't handle:

  • Pre-0.12 instruments:
    • PC Engine (imported as Standard)
    • Game Boy
    • Commodore 64

tildearrow avatar Apr 06 '22 20:04 tildearrow

Marking as done since I think I fixed that 22 bytes bug.

tildearrow avatar Sep 10 '22 22:09 tildearrow