furnace icon indicating copy to clipboard operation
furnace copied to clipboard

[NES 2A03 | linux] pattern editor volume column broken?

Open pablo-888 opened this issue 3 years ago • 6 comments

if I have an instrument that has the volume "0 15" in the macro window for example it works fine. But if I have something with more values (say 0 15 14 13 12 10 9) changing the volume in the pattern editor makes the instrument pizzicato instead of it having sustain like it normally does which breaks the ability to do echos/reverb like you can in famitracker for example.

it also breaks if you have an instrument that has more attack (say 0 3 5 6 10). it breaks with pretty much anything that's not a single volume value.

pablo-888 avatar May 05 '22 02:05 pablo-888

which system? any specific one?

freq-mod avatar May 05 '22 08:05 freq-mod

NES (Ricoh 2A03)

pablo-888 avatar May 05 '22 08:05 pablo-888

Unable to replicate on dev92.

https://user-images.githubusercontent.com/32672779/166890597-6e24d070-d5da-4d91-bd8b-680da67c1ea0.mp4

freq-mod avatar May 05 '22 08:05 freq-mod

No that's not what I meant in your example your instrument itself only has one volume value. It only happens when you add more. Here let me show you. (sorry the audio got a little distorted in the mp4 conversion but you get the idea)

https://user-images.githubusercontent.com/104789095/166891658-ca8d25ce-933a-41c2-b17b-f98ada2ea90e.mp4

pablo-888 avatar May 05 '22 08:05 pablo-888

This kind of also happens on famitracker though, the difference is that it clamps the volume to be the at minimum volume if the volume value is not 0, apparently. But also, Furnace volume scaling seems to be really bad compared to Famitracker

Weeppiko avatar May 05 '22 09:05 Weeppiko

Hmm... This issue is actually a DefleMask quirk - volume is trampled down (subtract) rather than being scaled (multiply). Not a bug.

However, a compatibility flag to select proper and bug behavior will be added.

tildearrow avatar May 05 '22 23:05 tildearrow

The compatibility flag has been there since 0.6pre1. Proper volume scaling is the default now.

tildearrow avatar Sep 10 '22 22:09 tildearrow