KernelSU icon indicating copy to clipboard operation
KernelSU copied to clipboard

kernel, ksud: collect binaries into /data/adb/ksu

Open skbeh opened this issue 2 years ago • 2 comments

skbeh avatar Jan 31 '23 07:01 skbeh

When the directory is created? /data/adb is created by Android, if you use its subdirectory, you should create it.

tiann avatar Jan 31 '23 11:01 tiann

When the directory is created? /data/adb is created by Android, if you use its subdirectory, you should create it.

It is created before usage.

skbeh avatar Jan 31 '23 13:01 skbeh

I will test it with my device later

tiann avatar Feb 01 '23 01:02 tiann

Please keep /data/adb/ksud the same, this command is useful for developers, we don't like to type more words. Other modification is OK.

tiann avatar Feb 01 '23 02:02 tiann

Please keep /data/adb/ksud the same, this command is useful for developers, we don't like to type more words. Other modification is OK.

Would you like to move it to somewhere in PATH?

skbeh avatar Feb 01 '23 02:02 skbeh

Or we can modify PATH for the commands which are executed by su.

skbeh avatar Feb 01 '23 02:02 skbeh

Please keep /data/adb/ksud the same, this command is useful for developers, we don't like to type more words. Other modification is OK.

Would you like to move it to somewhere in PATH?

We don't want to put it in $PATH, it is an internal implementation, not an API.

And it maybe move to some other place(such as /dev), we are planning to embed ksud to kernel, so don't do that.

tiann avatar Feb 01 '23 02:02 tiann

Would you like to embed busybox to gain some compatibility with magisk?

skbeh avatar Feb 01 '23 02:02 skbeh

Would you like to embed busybox to gain some compatibility with magisk?

we should do that

tiann avatar Feb 01 '23 03:02 tiann

@tiann BusyBox is licensed under GPLv2, so embedding it breaks the license. Also the linux kernel is licensed under GPLv2, so linking kernelsu with it also breaks license.

skbeh avatar Feb 01 '23 04:02 skbeh

I suggest to license kernelsu under GPLv2 or GPLv2-or-later.

skbeh avatar Feb 01 '23 04:02 skbeh

KernelSU is GPL-3 Isn't it compatible ?

tiann avatar Feb 01 '23 04:02 tiann

KernelSU is GPL-3

GPLv3 is not compatible with GPLv2.

skbeh avatar Feb 01 '23 04:02 skbeh

Magisk is also GPL3

tiann avatar Feb 01 '23 04:02 tiann

Magisk is also GPL3

Because magisk isn't linked with Linux kernel or GPLv2 libraries, they don't have to deal with the license problem.

skbeh avatar Feb 01 '23 04:02 skbeh

GPLv2-or-later should be Ok?Magisk is GPL3 and we use its reserprop

tiann avatar Feb 01 '23 05:02 tiann

GPLv2-or-later should be Ok

I think it should be. However, I am not a lawyer, so I can not give legal advices.

skbeh avatar Feb 01 '23 05:02 skbeh

I consulted the layer, kernel is gpl2 without later, so the kernel part of KernelSU must be gpl2 without later. So, I will relicense it under gpl2.

tiann avatar Feb 01 '23 07:02 tiann

The binaries are directly taken from Magisk v25.2 apk.

skbeh avatar Feb 01 '23 08:02 skbeh