thunderbird-conversations icon indicating copy to clipboard operation
thunderbird-conversations copied to clipboard

Integrate with "Copy Sent to Current" add-on

Open lkraav opened this issue 7 years ago • 8 comments

https://addons.thunderbird.net/en-US/thunderbird/addon/copy-sent-to-current/?src=search

This is a mature popular addon to control "Copy to Sent" function in a more fine-grained way. It works well w/ Thunderbird's standard messaging facilities.

I'm mostly interested in an optional "No copy" functionality for Conversations threads/replies, as we have other systems taking care of routing sent mail to correct shared folders.

PROBLEM Right now, everything in shared mailboxes coming from Conversations appear double - original message and sent copy both end up in "current" folder.

lkraav avatar Aug 03 '18 09:08 lkraav

Hi, I'm a bit surprised this doesn't "just work" however, it is possible conversations is doing something special that hasn't been accounted for.

Unfortunately we don't have time to look at this at the moment, so any integration work that is needed in Conversations would need to either come from an outside contributor or you might be able to ask the add-on author to take a look, e.g. the issue might be on their side.

We'd gladly welcome patches to make this better, but we don't have time to handle the investigations and work ourselves.

Standard8 avatar Aug 16 '18 09:08 Standard8

Hi, I'm a bit surprised this doesn't "just work" however, it is possible conversations is doing something special that hasn't been accounted for.

Regardless of the addon, if Conversations compose / reply box gained a checkbox titled "No copy", this would actually be enough to reach the goal.

Based on your tech knowledge of Conversations, is that a low, medium, high difficulty implementation?

lkraav avatar Aug 16 '18 16:08 lkraav

Regardless of the addon, if Conversations compose / reply box gained a checkbox titled "No copy", this would actually be enough to reach the goal.

Whilst that could be enough, I wouldn't accept a patch for it. Conversations should use what Thunderbird is configured for, not have its own additional settings - otherwise it'll just get confusing for the user as to how to control everything.

Based on your tech knowledge of Conversations, is that a low, medium, high difficulty implementation?

I think the key to this is actually understanding what Copy Sent to Current is actually doing, and then see how Conversation's workflow doesn't fit with that, or how its workflow doesn't fit with Conversations. Then we can work out what the actual fix should be.

For the Conversations side of things, start poking around the send function in ComposeSession in stub.compose-ui.js.

Standard8 avatar Aug 17 '18 08:08 Standard8

I use copy sent to current to select a folder to save the sent message in. be great if this could work. does the addon use a different means of sedning that bypasses other addons?

pcause avatar Aug 17 '18 12:08 pcause

Whilst that could be enough, I wouldn't accept a patch for it. Conversations should use what Thunderbird is configured for, not have its own additional settings - otherwise it'll just get confusing for the user as to how to control everything.

and

I use copy sent to current to select a folder to save the sent message in. be great if this could work. does the addon use a different means of sedning that bypasses other addons?

As @pcause also points out, this issue refers to a feature Thunderbird core currently doesn't have.

There are several valid use cases where it's valuable for the user to per-message override the default "Sent" folder target with another folder, or disable filing a "Sent" copy altogether.

@Standard8 are you saying if "Copy Sent to Current" addon functionality would be integrated into Thunderbird core, then Conversations would also gain a responsibility to implement it for feature parity?

Alternatively, another tech q here, does Conversations expose enough API that "Copy Sent to Current" addon could build an integration for Conversation? (we invert the responsibility)

lkraav avatar Aug 17 '18 12:08 lkraav

What I am trying to say is, that someone needs to investigate how "Copy Sent to Current" works, and how "Conversations" work, and why they don't work together. Once that is understood, then we can figure out the appropriate fix (which could be one or more patches within any combination of Thunderbird, Conversations or Copy Sent to Current).

I personally do not want to spend time investigating this, as I am spending my available time elsewhere maintaining the add-on and moving it forward in other areas. If someone else wants to look at it and provide a details + solution that we can agree, and then possibly a patch, then I am happy to work with them to get a fix landed in Conversations (if it needs it).

Standard8 avatar Aug 17 '18 12:08 Standard8

What I am trying to say is, that someone needs to investigate how "Copy Sent to Current" works, and how "Conversations" work, and why they don't work together.

Maybe a misunderstanding here: they work together just fine, but to an extent.

As the "per-message override" dropdown control I've been referring to, is displayed in TB message compose window, it never becomes available to Conversations users.

Anyway, I think enough non-tech information has been gathered. We'll see what can happen next and when.

lkraav avatar Aug 17 '18 20:08 lkraav

copy sent is a jar file and i don't see a link to source on the developers web site.

pcause avatar Oct 10 '18 19:10 pcause