hgrep icon indicating copy to clipboard operation
hgrep copied to clipboard

Prettier printing?

Open thumphries opened this issue 8 years ago • 3 comments

Question for all, how would you improve the current output to make it easier to visually navigate?

I spent a few minutes messing around and came up with this boxy rendering, not sure if I like it or not:

screen shot 2017-10-13 at 7 56 23 pm screen shot 2017-10-13 at 7 58 54 pm

thumphries avatar Oct 13 '17 09:10 thumphries

I see three changes:

  1. Coloured function names: I like this! Currently it seems I only get that with -n.
  2. Filename aligned with code: this looks a bit neater but I don't know if it would look as nice without the box characters.
  3. The box characters: I think I could do without this. It seems purely decorative and I don't think it would help me visually scan the output any easier. I also wonder if this would necessitate a -b or --no-boxes flag if it does end up in hgrep.

vaibhavsagar avatar Oct 14 '17 05:10 vaibhavsagar

The coloured function names should be happening now, it's a bug! line numbers are prepended before everything is sent to hscolour.

Not sure if I like the boxy rendering either. Undecided. It probably doesn't matter, what we have is nice enough. I'll re-evaluate as we slowly start to report more information.

thumphries avatar Oct 14 '17 07:10 thumphries

@thumphries I'm voting for boxy rendering. I like the new output!

chshersh avatar Sep 03 '18 04:09 chshersh