Magic-Sand icon indicating copy to clipboard operation
Magic-Sand copied to clipboard

reserved identifier violation

Open elfring opened this issue 9 years ago • 2 comments

I would like to point out that identifiers like "DLIB_CBLAS_CONSTAnTS_H__" and "__GreatSand__SandSurfaceRenderer__" do eventually not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

elfring avatar Jul 31 '16 13:07 elfring

How do you think about to avoid that this software depends on undefined behaviour?

elfring avatar Oct 26 '20 20:10 elfring

Hi! Sorry for closing the issue prematurely and thanks for your code review. We will try to address the issues when we hopefully have time for another iteration.

RasmusRPaulsen avatar Oct 27 '20 07:10 RasmusRPaulsen