bootswatch

bootswatch copied to clipboard

We are using Slate and Simplex to switch between dark and light themes due to their similarity in overall style. However, there's one key issue that appears to be a bug: the --bs-btn-padding-x and --bs-btn-padding-y fields in .btn are set to 1rem and 0.75rem respectively, while the corresponding values in Simplex are 0.75rem and 0.375rem.

This issue makes the Slate default buttons actually appear the same size as the .btn-lg variants (at least in height), while the Simplex buttons correctly step down in size from .btn-lg to .btn to .btn-sm. This issue can also be seen on the live previews for Slate and Simplex, specifically in the row that shows the 3 button sizes.

For now, I have simply overridden these values in my local code, but it would be great to see them fixed in the repo itself. The offending lines are 2813 and 2814 of the dist/slate/bootstrap.css file. Thanks in advance!

Hi @iamtheddrman, Slate and Simplex weren't intended as dark/light complements of each other in the same way as Flatly and Darkly. They're meant to have distinct styles with many differences including button padding.

With that said, a light version of Slate might be in the cards if there's interest for that.

Thanks for the quick reply! A light version of Slate would be a fantastic addition. How much effort would that be, and is there anything I can do to officially request it and/or help? Flatly/Darkly look great but don't match the general look-and-feel we are working towards in our application the way that Slate does (and Simplex does as well).

I can certainly understand that they aren't intentionally light/dark counterparts but there does seem to be a rather extreme number of things in common, and Slate was changed from our (admittedly very old) version based on Bootstrap 3 w.r.t. the padding and overall size of the standard/default button size. I guess that's why I saw it as a bug rather than a feature.

@thomaspark I just wanted to circle back on this and see if you had any insight on the above request. Is this something I should try to tackle in a fork and put in a PR, or are the styles something done only by official contributors?

Hey @iamtheddrman, I've started work on a light version of Slate called Ceramic, but haven't gotten far yet.

The goals of this theme are to make it as pixel perfect of a match to Slate, and the sass source as similar (therefore low maintenance) as possible.

If this is something you feel you can tackle, a PR is always welcome.