Tom McLaughlin
Tom McLaughlin
Thanks @prednaz ! From what I can tell, the warning you reference applies only to `OverlappingInstances` and not to the newer `OVERLAPPING` pragmas. So, it seems like all we really...
Thanks! `checkIllegalName` seems not to be used anywhere though :P Also, could you move the function to `Util.hs` or perhaps `Formatting.hs`? FWIW, if something like this has a tendency to...
Oh right, that's unfortunate. I don't love the idea of a breaking change to the name formatters API, although in hindsight it seems like the `ExtraTypeScriptOptions` might have been a...
Setting the default name formatter to error out as you describe sounds like a good first step. Maybe that would be sufficient to close #34 ? If you get an...
> I wouldn't want to introduce a runtime dependency on `tsc` Huh? There's no `tsc` involved in the idea of erroring out at the formatting stage by using `checkIllegalNameChars`. Just...
All right, what do you think of the following? 1) In this PR, do the erroring `defaultNameFormatter` 2) Make a subsequent PR moving the formatting functions to the `ExtraTypeScriptOptions`, and...
Sorry, this fell off my radar -- merging now!
Automatic merge failed, manually rebased and merged in ba5d998
This [function](https://github.com/codedownio/aeson-typescript/blob/1066fb8d72e642bfd4e2317e3a1f31be049e11ab/test/TestBoilerplate.hs#L66) derives instances for a bunch of examples, which are then tested against various Aeson `Options` in the different test files. I guess you could add some more types...
I'll go ahead and merge this and see if I can add some tests...