things.py icon indicating copy to clipboard operation
things.py copied to clipboard

Published 20 hours ago • verified publisher icon thingsapi

add exact date query to enable logyesterday

Open bkleinen opened this issue 2 years ago • 1 comments

to be able to cleanly implement https://github.com/thingsapi/things-cli/issues/9 an exact date match is needed in the api.

bkleinen avatar Nov 30 '22 20:11 bkleinen

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Dec 02 '22 22:12 sonarqubecloud[bot]

@bkleinen Thank you for the pull request and patience. :) My comments here relate to the files in things/*; @AlexanderWillner might comment on the workflows/tests.

I like the proposal, and want to offer a slight tweak. Instead of doing exact=, I'd suggest to use the following syntax:

  • stop_date="=2023-05-01"
  • stop_date="<=2023-05-01"
  • stop_date=">=2023-05-01"

Without the comparator-prefix, the defaults could then always be ">=":

  • start_date="2023-05-01" (same as ">=2023-05-01")
  • stop_date="2023-05-01" (same as ">=2023-05-01")
  • deadline="2023-05-01" (same as ">=2023-05-01")

mikez avatar May 01 '23 11:05 mikez

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar May 21 '23 21:05 sonarqubecloud[bot]

Follow-up: Implemented this syntax but chose no operator to mean exact match, so stop_date="2023-05-01" is the same as stop_date="=2023-05-01" or stop_date="==2023-05-01"

mikez avatar May 22 '23 14:05 mikez