react-native-schemes-manager icon indicating copy to clipboard operation
react-native-schemes-manager copied to clipboard

Published 20 hours ago • verified publisher icon thekevinbrown

Changed so glob does not follow symlinks.

Open DanFlor opened this issue 6 years ago • 1 comments

Circular symlinks in modules were breaking the script.

Description of changes

Changed the glob call in utilities.js to not follow symlinks. See issue #66 for details.

Related issues (if any)

#66

DanFlor avatar Mar 19 '19 15:03 DanFlor

@DanFlor, thanks for the contribution. I think the use case that necessitated following symlinks was when people use npm link to bring a module in for development, which we still wanted to modify the .xcodeproj for.

I think it's probably a bit of an edge case, given that the React project is the one we're really after, so I'm open to merging this change, but I'd recommend changing it from { follow: false } to just omitting the options object, as that's the default behaviour of the library.

thekevinbrown avatar Mar 25 '19 02:03 thekevinbrown