foreman icon indicating copy to clipboard operation
foreman copied to clipboard

Fixes #35124 - Fix preseed_kernel_options for bootdisk-deployments

Open jtruestedt opened this issue 3 years ago • 8 comments

To make it possible to use full-host ISO with static network configurations for Debian/Ubuntu it is needed to add the network configuration in the templates. This is build similar to the kickstart_kernel_options snippet.

jtruestedt avatar Jun 28 '22 14:06 jtruestedt

Can one of the admins verify this patch?

theforeman-bot avatar Jun 28 '22 14:06 theforeman-bot

Can one of the admins verify this patch?

theforeman-bot avatar Jun 28 '22 14:06 theforeman-bot

Can one of the admins verify this patch?

theforeman-bot avatar Jun 28 '22 14:06 theforeman-bot

Issues: #35124

theforeman-bot avatar Jun 28 '22 14:06 theforeman-bot

ok to test

Ron-Lavi avatar Jul 06 '22 08:07 Ron-Lavi

[test unit] [test integration]

evgeni avatar Aug 19 '22 07:08 evgeni

This will require re-recording of the snapshots once the code changes are final.

Ping if you need help doing so!

evgeni avatar Aug 19 '22 08:08 evgeni

I've updated the snapshots and tests look fine IMHO. @evgeni do you think the katello issue is related to this change?

bastian-src avatar Sep 05 '22 13:09 bastian-src

Thank you for your contribution, @jtruestedt! This PR has been inactive for 3 months, closing for now. Feel free to reopen when you return to it. This is an automated process.

theforeman-bot avatar Dec 20 '22 01:12 theforeman-bot

Would be good to get this PR done.

sbernhard avatar Dec 20 '22 08:12 sbernhard

from my understanding we wait on a rereview from someone like @evgeni ? At least I do not see something at the moment, where anything blocks, which I could resolve.

please correct me if I am wrong

jtruestedt avatar Jan 11 '23 12:01 jtruestedt

from my understanding we wait on a rereview from someone like @evgeni ? At least I do not see something at the moment, where anything blocks, which I could resolve.

please correct me if I am wrong

Yep! You're absolutely right, we're waiting for a review - still, you can rebase to the current develop branch.

bastian-src avatar Jan 12 '23 09:01 bastian-src

Thank you for your contribution, @jtruestedt! This PR has been inactive for 3 months, closing for now. Feel free to reopen when you return to it. This is an automated process.

theforeman-bot avatar May 11 '23 01:05 theforeman-bot

@evgeni Do you mind having another look? We would like to bring this forward!

nadjaheitmann avatar Jun 15 '23 08:06 nadjaheitmann

Katello test failure seems unrelated

nadjaheitmann avatar Jul 13 '23 11:07 nadjaheitmann

Thanks!

Sorry it took so long to get it in.

evgeni avatar Aug 23 '23 06:08 evgeni