Fixes #35124 - Fix preseed_kernel_options for bootdisk-deployments
To make it possible to use full-host ISO with static network configurations for Debian/Ubuntu it is needed to add the network configuration in the templates. This is build similar to the kickstart_kernel_options snippet.
Can one of the admins verify this patch?
Can one of the admins verify this patch?
Can one of the admins verify this patch?
Issues: #35124
ok to test
[test unit] [test integration]
This will require re-recording of the snapshots once the code changes are final.
Ping if you need help doing so!
I've updated the snapshots and tests look fine IMHO. @evgeni do you think the katello issue is related to this change?
Thank you for your contribution, @jtruestedt! This PR has been inactive for 3 months, closing for now. Feel free to reopen when you return to it. This is an automated process.
Would be good to get this PR done.
from my understanding we wait on a rereview from someone like @evgeni ? At least I do not see something at the moment, where anything blocks, which I could resolve.
please correct me if I am wrong
from my understanding we wait on a rereview from someone like @evgeni ? At least I do not see something at the moment, where anything blocks, which I could resolve.
please correct me if I am wrong
Yep! You're absolutely right, we're waiting for a review - still, you can rebase to the current develop branch.
Thank you for your contribution, @jtruestedt! This PR has been inactive for 3 months, closing for now. Feel free to reopen when you return to it. This is an automated process.
@evgeni Do you mind having another look? We would like to bring this forward!
Katello test failure seems unrelated
Thanks!
Sorry it took so long to get it in.