apollo-errors

apollo-errors copied to clipboard

Recently, GraphQL Response Specification got updated with a suggestion to place custom data in error in the extensions object. The spec can be found here https://github.com/facebook/graphql/blob/master/spec/Section%207%20--%20Response.md

An excerpt of the relevant section:

GraphQL services may provide an additional entry to errors with key extensions. This entry, if set, must have a map as its value. This entry is reserved for implementors to add additional information to errors however they see fit, and there are no additional restrictions on its contents.

{
  "errors": [
    {
      "message": "Name for character with ID 1002 could not be fetched.",
      "locations": [ { "line": 6, "column": 7 } ],
      "path": [ "hero", "heroFriends", 1, "name" ],
      "extensions": {
        "code": "CAN_NOT_FETCH_BY_ID",
        "timestamp": "Fri Feb 9 14:33:09 UTC 2018"
      }
    }
  ]
}

PRs are welcome! I'd don't really have time to make this update at the moment

Sure man PR at #35

Thanks! Merged! If you wanna have a whack at fixing 1.7.1 bugs and add more test coverage, I am also happy to merge more PRs. I can't release this (2.0.0, since it's a breaking change) until we get the bugs from the TS refactor sorted out. Also, I am looking for additional core contributors if you are interested

Thanks! I sent a PR for the constructor fix in #34.

The fix is very similar to #29. But one difference is that newConfig or (arguments[2]) have the highest precedent when merging. It also make sure to merge data and options.

I can rebase on top of the reverted on top of the reverted PR and continue the discussion from there.

@thebigredgeek I'm using this heavily in a few projects and plan on releasing an open source boilerplate that includes it, I'm more than willing to help maintain it.

I can help in an ad hoc and second opinion manner.

Can we create a second PR for this? I'd like to release in 2.0

Bump

Sorry I miss this message. I'll try send a PR your way today or tomorrow!

@lxcid @thebigredgeek bump

Why has #35 been reverted 🤔

@lxcid Could you make another PR against version-2 ?

This should be against version 2 should it not? I think that was why I reverted originally, too much push back about the breaking change.

sorry for the afk, i try to work on it now…

Hi, @thebigredgeek I notice that lxcid's PR is in the version-2 branch, but npm is still at 1.9.0.

Is it ok to use version-2, or are there still some remaining issues?

@lxcid was this ever completed and merged?

@thebigredgeek How can I help resolve this issue and get V2 published? Right now we're monkey-patching the error response object at the last second as a workaround. Should we switch over to a different package that is better supported? Thanks for any help. cc: @jonesmac @tarazena @mwlevel20

Is there anything anybody can do to move this forwards and get 2.0 released?

@kylewhitaker you can put together a PR that implements the desired functionality to resume spec compliance, against version 2. Once that is done I'll release it