organize icon indicating copy to clipboard operation
organize copied to clipboard

Speed issue with v2, and issue with losing modified date/time.

Open Nurple opened this issue 3 years ago • 4 comments

Heya,

I updated my config for v2 and noticed there's a big diffence in speed, what took a few seconds in v1 is taking minutes in v2, also the modified date/time gets changed to the current time.

I'm probably doing something wrong in my config.

Expected behavior: Speed of task to be the same, and not have the modified date/time be changed to the current time.

Environment:

  • OS: Windows 10 - 21H2 - x64
  • Python Version: v3.10.3
  • Organize Version: v2.1.2

Your config file

rules:
  - locations: "D:/GoPro/"
    subfolders: true
    filters:
      - extension:
          - mp4
      - lastmodified
    actions:
      - move: "D:/GoPro Sorted/{lastmodified.strftime('%Y-%m-%d')}/"

Nurple avatar Apr 06 '22 01:04 Nurple

Hey, you're hitting an unoptimized code path in the underlyingpyfilesystem library. I submitted a PR to pyfilesystem which should fix this (https://github.com/PyFilesystem/pyfilesystem2/pull/523). So this should be fixed as soon as they do a new release.

tfeldmann avatar Apr 29 '22 10:04 tfeldmann

Oh OK, thanks for letting me know, and thanks for the app :)

Nurple avatar May 07 '22 15:05 Nurple

PyFilesystem did release a new version and this should be fixed now. Can you check again? Please make sure to run pip3 install -U fs before or install the latest organize version.

tfeldmann avatar Aug 17 '22 17:08 tfeldmann

Edit: Seems I was wrong, speed issue isn't fixed, guess the files I tested were still in ram.

The latest version of fs on pypi.org is 2.4.16 (Released: May 2, 2022), so that makes sense.


Heya, sorry for the late reply.

Just checked and the speed issue seems to be fixed now, but the issue with the modified date/time is still there though.

Nurple avatar Aug 26 '22 13:08 Nurple

It also confuse me a lot.

vipsbpig avatar Nov 02 '22 09:11 vipsbpig

Hi and thank you for a great tool. Does anyone know how to fix the issue with modified/create datetime changed to current on copy/move actions?

stantyan avatar Jul 10 '23 14:07 stantyan

I just released v3 as a pre-release (infos in the repo's readme).

The speed issues and strange metadata issues came from the pyfilesystem library which is now removed completely. @Nurple running your config should take seconds again!

tfeldmann avatar Jan 03 '24 09:01 tfeldmann

Heya, sorry for late reply, all seems fine now. Thanks.

Nurple avatar Feb 04 '24 14:02 Nurple

Np, thanks for the update!

tfeldmann avatar Feb 04 '24 15:02 tfeldmann