tfardet

Results 66 comments of tfardet

Thanks for the reply. Git send-email indeed relies on plaintext but text/html should not be used anywhere so this should not be the problem. Unfortunately I already switched to Hydroxide,...

Actually comparing the diff between the [actual applied patch](https://git.sr.ht/~tfardet/NNGT/commit/0d128b074cde65192749de7c9e642c48d442c1fd#nngt/analysis/gt_functions.py) and the [proposed patch](https://lists.sr.ht/~tfardet/nngt-developers/patches/20470#%[email protected]%3E+nngt/analysis/gt_functions.py), one can see a missing whitespace on the newline after ``u = GraphView(u, efilt=label_parallel_edges(u).fa == 0)``

Hi there, sorry to bump the issue but I was wondering whether there had been any progress: bug is still present on 1.8.7 and since you are now checking for...

Also, since a example was asked: 1. Send an email to yourself: ``` This is a test email with whitespaces on newlines. There is a whitespace on the lines above...

@andrzejsza after reading through most of the code I thought could be relevant, I believe the bug comes from [``gopenpgp``](https://github.com/ProtonMail/gopenpgp): In the bridge, [``writeEncryptedTextPart``](https://github.com/ProtonMail/proton-bridge/blob/master/pkg/message/encrypt.go#L120) is calling [``crypto.NewPlainMessage``](https://github.com/ProtonMail/gopenpgp/blob/3dd1711707c052f97bc53cd3be2dd690e12452b2/crypto/message.go#L89) on [line 129](https://github.com/ProtonMail/proton-bridge/blob/master/pkg/message/encrypt.go#L129)....

OK, I don't know, then... could anyone please just check whether they can actually reproduce the bug and, if so, could someone who knows what they're doing (unlike me) check...

OK, thanks for checking, but in my previous message I also mentioned that ``crypto.NewPlainMessage`` is calling ``CanonicalizeAndTrim`` so I'm not sure why you expect this change to solve the issue......

Ah, then it's not the one from ``gopenpgp`` I guess, because [that one](https://github.com/ProtonMail/gopenpgp/blob/3dd1711707c052f97bc53cd3be2dd690e12452b2/crypto/message.go#L89) does call ``CanonicalizeAndTrim``... Could you link where that version of the function comes from?

> Hey, finally got a chance to look into this. > > The parts in the code you linked to are unrelated (they're used for importing messages, not sending/building). >...