GitHub-Markdown.tmbundle icon indicating copy to clipboard operation
GitHub-Markdown.tmbundle copied to clipboard

Add support for Crystal code blocks

Open hovsater opened this issue 4 years ago β€’ 11 comments

Add support for Crystal code blocks.

Screenshot 2021-07-12 at 09 25 43

hovsater avatar Jul 12 '21 07:07 hovsater

@infininight would you mind taking a look at this? πŸ™‚

hovsater avatar Jul 12 '21 07:07 hovsater

Looks good to me, @noniq will have to pull it in though as I'm not sure what he's doing with the integration here.

infininight avatar Jul 15 '21 23:07 infininight

Looks like I don't have the necessary permissions to override / fix the continuous integration checks in this bundle. Anyone else?

noniq avatar Jul 18 '21 15:07 noniq

@noniq Your the only one on the bundle other than me and Allan. I've stared at this permissions guide for 10 minutes and fail to see what permissions you need for that, doesn't seem to be listed?

Edit: Oh it's a webhook, not an integration, that requires admin level access. Do you know what you want the settings to be there? Or should it be active, etc?

infininight avatar Jul 18 '21 17:07 infininight

I think this CI check was set up when @MikeMcQuaid was maintaining the repo. I don’t really have an idea how to make it work again, so I think we should just disable it for now.

noniq avatar Jul 18 '21 21:07 noniq

What it's doing is pretty simple: https://github.com/textmate/GitHub-Markdown.tmbundle/blob/2b58b061e3a59d794b1c5e3a87526f2a544898f2/.travis.yml#L2-L3

If desired/useful I can submit a PR to update to GitHub Actions. If not: no worries.

MikeMcQuaid avatar Jul 19 '21 13:07 MikeMcQuaid

So what did we decide here? @MikeMcQuaid do you want to take a stab at migrating to GitHub actions instead? πŸ™‚

hovsater avatar Sep 09 '21 08:09 hovsater

@kevinsjoberg Opened https://github.com/textmate/GitHub-Markdown.tmbundle/pull/36. Think @noniq will need to enable (or perhaps temporarily add me as a collaborator to setup and merge).

@noniq While you're here if you can merge https://github.com/mikemcquaid/GitHub-Markdown-Font-Settings.tmbundle too that'd be handy!

MikeMcQuaid avatar Sep 14 '21 09:09 MikeMcQuaid

@MikeMcQuaid I don't have the permissions (as far as I see) to add new collaborators, but @infininight or @sorbits should be able to do it.

noniq avatar Sep 14 '21 16:09 noniq

@infininight do you have the proper permissions? πŸ™‚

hovsater avatar Jan 30 '22 18:01 hovsater

@sorbits do you have the proper permissions? πŸ™‚

hovsater avatar Apr 07 '22 13:04 hovsater