jest-native icon indicating copy to clipboard operation
jest-native copied to clipboard

chore: eslint setup

Open mdjastrzebski opened this issue 3 years ago • 1 comments

What:

Setup ESLint validation with reasonable rules. Fix remaining rule violations.

Also:

  • removed Husky reformatting hook in favor of ESLint also checking formatting.
  • switch to plain Yarn because of install issues with NPM & npm-install action (no noticable perf impact on CI runs)

Why:

Extra safety net on the CI for code quality assurance.

How:

  • Added eslint deps
  • Set reasonable rules based on RNTL rules
  • Added linter step to GH action

Checklist:

  • [x] Documentation added to the docs
  • [x] Typescript definitions updated
  • [x] Tests
  • [x] Ready to be merged

mdjastrzebski avatar Aug 11 '22 09:08 mdjastrzebski

Codecov Report

Merging #99 (4b20b72) into main (5421f95) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #99   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          151       151           
  Branches        51        51           
=========================================
  Hits           151       151           
Flag Coverage Δ
node-14 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)
node-18 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils.js 100.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 11 '22 09:08 codecov[bot]

:tada: This PR is included in version 4.0.12 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Sep 15 '22 10:09 github-actions[bot]