fastapi-sqlmodel-alembic icon indicating copy to clipboard operation
fastapi-sqlmodel-alembic copied to clipboard

Published 20 hours ago • verified publisher icon testdrivenio

Project update

Open jonra1993 opened this issue 3 years ago • 2 comments

Thanks for this fast API setup. In this Pull request, I have added some suggestions on issues

  1. nullable=False on id to avoid problems on migrations
  2. settings file
  3. db file upgrade
  4. readme add how to make migrations with alembic

jonra1993 avatar Mar 12 '22 16:03 jonra1993

Thanks. Since the project is tied to a tutorial -- https://testdriven.io/blog/fastapi-sqlmodel/ -- the code and tutorial need to be updated at the same time. I should have some time later this month to look at this.

mjhea0 avatar Mar 13 '22 13:03 mjhea0

Apologies for the delay, @jonra1993. It's really difficult to accept PRs from folks who are not also updating the tutorial at the same time. @amirtds and I updated both. We captured most of your changes. If you still want to contribute, please address the merge conflicts. Thank you!

mjhea0 avatar Jul 10 '23 20:07 mjhea0