testcontainers-java icon indicating copy to clipboard operation
testcontainers-java copied to clipboard

Published 20 hours ago • verified publisher icon testcontainers

getLivenessCheckPortNumbers() should return mapped port

Open aidando73 opened this issue 3 years ago • 5 comments

Addresses issue https://github.com/testcontainers/testcontainers-java/issues/5283

aidando73 avatar Aug 16 '22 12:08 aidando73

Thank you @kiview for the review - I've addressed your comments. I'm feeling more comfortable with this PR now as it gets rid of dead code and increases meaningful test coverage.

aidando73 avatar Aug 18 '22 12:08 aidando73

I've updated this with master - hopefully that fixes the build

aidando73 avatar Aug 19 '22 03:08 aidando73

Ah yes, sorry about this @REslim30. There was an issue with a republished Gradle plugin from which master suffered.

kiview avatar Aug 19 '22 15:08 kiview

Updated the PR, since CI was failing because of #5761.

kiview avatar Aug 23 '22 09:08 kiview

Thank you @eddumelendez for the review.

I've addressed your suggestions. Merged in master as well.

aidando73 avatar Sep 03 '22 03:09 aidando73

Thanks for this nice cleanup PR @REslim30.

kiview avatar Sep 28 '22 10:09 kiview