testcontainers-java icon indicating copy to clipboard operation
testcontainers-java copied to clipboard

Published 20 hours ago • verified publisher icon testcontainers

VncRecordingContainer creates an unnecessary delay during video export.

Open nachg opened this issue 3 years ago • 5 comments

nachg avatar Apr 14 '22 14:04 nachg

Hey @nachg, can you please add a bit more context to the PR?

kiview avatar Aug 08 '22 13:08 kiview

Hey @nachg, can you please add a bit more context to the PR? I put context here: https://github.com/testcontainers/testcontainers-java/issues/5268

nachg avatar Aug 09 '22 09:08 nachg

Can you please elaborate on how copying the file before reencoding fixes the issue at hand?

kiview avatar Aug 09 '22 10:08 kiview

Can you please elaborate on how copying the file before reencoding fixes the issue at hand?

VNC recorder working with the output file as with a stream. If we will start the encoding process on that file, it length will be increased during the process. That's why I create a copy - to "stop" extanding the file length by the VNC. Another possible solution is to stop the VNC process and run encoding after it. But I was not able to find the way how it can be done.

nachg avatar Aug 09 '22 13:08 nachg

Another possible solution is to stop the VNC process and run encoding after it. But I was not able to find the way how it can be done.

Here is how I've hacked it up: https://github.com/testcontainers/testcontainers-java/discussions/6229

I plan to submit a PR to stop the recording after the test is done.

deejgregor avatar Nov 22 '22 22:11 deejgregor