tflint-ruleset-terraform icon indicating copy to clipboard operation
tflint-ruleset-terraform copied to clipboard

Published 20 hours ago • verified publisher icon terraform-linters

`unused_required_providers`: implement autofix

Open bendrucker opened this issue 2 years ago • 2 comments

Implements autofix for terraform_unused_required_providers, on top of #93

bendrucker avatar Jun 13 '23 00:06 bendrucker

Hmm, I don't know that it necessarily makes #21 much worse. People who have hit that either disabled the rule or added tflint-ignore comments. It could be slightly more confusing, i.e. auto fix might make you more liable to think TFLint is right and your code is wrong.

bendrucker avatar Jun 14 '23 18:06 bendrucker

auto fix might make you more liable to think TFLint is right and your code is wrong.

Yes, I'm concerned about this possibility.

But for those who haven't faced this issue, autofix is obviously useful. So I approve of this change. I respect your decision to merge or not.

If you do merge, please rebase against the main branch as the base branch has been updated.

wata727 avatar Jun 15 '23 13:06 wata727