terraform-google-kubernetes-engine icon indicating copy to clipboard operation
terraform-google-kubernetes-engine copied to clipboard

Published 20 hours ago • verified publisher icon terraform-google-modules

Use map type for labels in modules/hub

Open justicel opened this issue 3 years ago • 1 comments

TL;DR

All other resource types and TF modules I've run across for GCP use a map type when defining labels. Instead, the 'hub' submodule appears to require a comma separated string for labels. Instead, we should use Terraform to combine/concat the labels map in to the proper format that the script needs when it runs. This will reduce complexity and bugs when using inherited variables files.

Terraform Resources

No response

Detailed design

No response

Additional information

No response

justicel avatar Jan 20 '22 19:01 justicel

This seems reasonable, though not a high priority. We would be happy to review a PR.

morgante avatar Jan 20 '22 19:01 morgante