terraform-aws-rds-aurora

terraform-aws-rds-aurora copied to clipboard

Description

Updated the module to add feature to create parameter group for aws-rds-aurora cluster and instances. The idea is to provision the groups (optionally of course) with the needed params set. This feature is already supported by terraform-aws-rds module please take a look here: https://registry.terraform.io/modules/terraform-aws-modules/rds/aws/latest#input_parameters . Added the variable to handle the autoscaling_policy_name dynamically as the current module has a hardcoded name for autoscaling_policy_name.

Motivation and Context

Currently we’re facing the issue where there is no way to create parameter group for aws-rds-aurora cluster and instances using the module. This PR resolve the issue reported here: https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/issues/279

Breaking Changes

This change does not break anything.

How Has This Been Tested?

• [x] I have updated at least one of the examples/parameter_group to demonstrate and validate my change(s)
• [x] I have tested and validated these changes using one or more of the provided examples/parameter_group projects
• [x] A new DB cluster was created with the instances and parameter groups. All went well.
• [x] Autoscaling policy was created with the name given using the autoscaling_policy_name variable. All went well.

@antonbabenko Please review the PR.

@bryantbiggs please review the PR, we have updated the changes as suggested.

@bryantbiggs we have updated the changes as requested, can we plz get this reviewed and merged so that we can use reference the registry directly? Thanks in advance.

@huzaifa-binafzal / @haytham-salhi I can't push to your PR so I opened a PR against it here https://github.com/HarriLLC/terraform-aws-rds-aurora/pull/10

Hi @bryantbiggs, changes has been merged. Can we plz get it merged and reviewed? Thanks!

Thanks @antonbabenko. Requested changed has been reflected.

This PR is included in version 7.3.0 :tada:

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.