terraform-aws-rds-aurora

terraform-aws-rds-aurora copied to clipboard

Is your request related to a new offering from AWS?

The feature is already available.

Is your request related to a problem? Please describe.

The problem is we cannot pass the params in this module like terraform-aws-rds module. See https://registry.terraform.io/modules/terraform-aws-modules/rds/aws/latest#input_parameters

Describe the solution you'd like.

We need to have the ability to pass the parameters like in this module: https://registry.terraform.io/modules/terraform-aws-modules/rds/aws/latest#input_parameters

Describe alternatives you've considered.

Forking the module and adding the custom implementation there, which is smth not recommended.

Additional context

N/A

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

Hi @bryantbiggs, any updates on this enhancement?

PRs are welcomed

@haytham-salhi what paramaters do you want to pass in exactly? ill take a look.

db_cluster_db_instance_parameter_group_name and db_cluster_parameter_group_name are already available so can you clarify what exactly you want. @haytham-salhi

Hi @travis-jorge , thanks for your comments.

What you are saying is right regarding the db_cluster_db_instance_parameter_group_name and db_cluster_parameter_group_name. But what is requested is slightly different: we need to pass the input params themselves with their values instead of the group names. The idea is to provision the groups (optionally of course) with the needed params set. Exactly like terraform-aws-modules/rds module, please take a look here: https://registry.terraform.io/modules/terraform-aws-modules/rds/aws/latest#input_parameters. Here's an example from terraform-aws-modules/rds module:

So in aurora-based clusters, we can have like instance_parameters and cluster_parameters as input variables; each representing a list of parameters (map) to apply.

Hope it is clear now. Thanks for your help!

Ok I see yea when I get some time I’ll take a look at this.

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

Just ran into this issue as well, and commenting to prevent the issue from becoming closed

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

Thanks @travis-jorge, have you got a chance to look at this?

@travis-jorge @bryantbiggs we have created a PR to support this issue please review: https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/pull/307

Hi @antonbabenko and @travis-jorge, we have already implemented this feature here: https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/pull/307. Can you plz review and merge?

This issue has been resolved in version 7.3.0 :tada:

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.