tfjs-core icon indicating copy to clipboard operation
tfjs-core copied to clipboard

Add rn integration test app

Open tafsiri opened this issue 6 years ago • 5 comments

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This adds an app that can serve as an integration testbed for tfjs-react-native. The PR looks somewhat big because there is a fair amount of generated iOS and Android boilerplate. The files that needs review all end in .ts .js and .tsx (and the regular js and ts configuration files we are used to). A few assets that the app uses are also included. The android and ios subfolders are pretty much all autogenerated.


This change is Reviewable

tafsiri avatar Aug 09 '19 20:08 tafsiri

Can we avoid checking in the generated files? It would be good to keep the clone time small on slow connections (already a big issue).

nsthorat avatar Aug 12 '19 15:08 nsthorat

Clarified in person, that by autogenerated I meant boilerplate that we don't need to change, but not code that can be generated on the fly.

However I will look into:

  • [x] Using a smaller model for the bundleLoader test.

tafsiri avatar Aug 12 '19 15:08 tafsiri

The monorepo is done, let's move this PR there: https://github.com/tensorflow/tfjs

nsthorat avatar Aug 13 '19 15:08 nsthorat

@tafsiri before you move this PR, can you reply to my comments here. Once we wrap up the discussions, I can LGTM here, and then you can simply open a PR in the union repo.

dsmilkov avatar Aug 13 '19 15:08 dsmilkov

@dsmilkov yep will finish it here and then remake against new repo.

tafsiri avatar Aug 14 '19 00:08 tafsiri