models icon indicating copy to clipboard operation
models copied to clipboard

FIX - Copy setup script before pip

Open eugriner opened this issue 2 years ago • 2 comments

Description

When running pip install . fails to find setup.py, to avoid that first one must copy the setup script to models/research/

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] Documentation update

Tests

Run it inside Google Colab

Test Configuration:

Google Colab's default config

Checklist

  • [x] I have signed the Contributor License Agreement.
  • [x] I have read guidelines for pull request.
  • [x] My code follows the coding guidelines.
  • [x] I have performed a self code review of my own code.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [x] I have made corresponding changes to the documentation.
  • [x] My changes generate no new warnings.
  • [x] I have added tests that prove my fix is effective or that my feature works.

eugriner avatar Jan 26 '23 17:01 eugriner

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jan 26 '23 17:01 google-cla[bot]

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB