metadata icon indicating copy to clipboard operation
metadata copied to clipboard

Published 20 hours ago • verified publisher icon tensorflow

Update the protobuf dependency?

Open NeilGirdhar opened this issue 3 years ago • 13 comments

Could the protobuf dependency be incremented by two major versions please?

NeilGirdhar avatar Jul 14 '22 17:07 NeilGirdhar

To make a case for this ticket, many libraries are now requiring protobuf>4. Meaning that tensorflow-metadata is blocking codebases from upgrading all these other libraries.

chhabrakadabra avatar Sep 30 '22 20:09 chhabrakadabra

it looks like this is holding us back from upgrading to tensorflow 2.12.0 and using protobuf 4 for any use case that requires tensorflow-metadata, or tensorflow-datasets which requires tensorflow-metadata

mattb-zip avatar Mar 31 '23 06:03 mattb-zip

any word on this?

coreyhu avatar Apr 04 '23 16:04 coreyhu

any updates?

elgalu avatar Oct 04 '23 16:10 elgalu

@rtg0795 Would you mind taking a look at this?

NeilGirdhar avatar Nov 03 '23 11:11 NeilGirdhar

Any updates on this?

EDIT: If you could publish any changes that loosen the Protobuf dependency as tensorflow-metadata==1.14.1 that would be appreciated. A 1.15.0 release with the loosened Protobuf dependency would be worthless without re-releasing all the Tensorflow libraries that depend on tensorflow-metadata because they're all scoped to tensorflow-metadata<1.15.0.

masonkirchner avatar Nov 27 '23 21:11 masonkirchner

@NeilGirdhar Hi. I see that 'protobuf>=3.20.3,<4.21' has been used for 1.14.0. Can you please explain or provide more details on why this is not sufficient?

rtg0795 avatar Jan 02 '24 21:01 rtg0795

@rtg0795 I'll let others comment more on this, but if I remember, this was preventing upgrades to Python 3.12. See also: https://github.com/tensorflow/metadata/issues/37#issuecomment-1263995064 and https://github.com/tensorflow/metadata/issues/37#issuecomment-1491387336

NeilGirdhar avatar Jan 03 '24 02:01 NeilGirdhar

@rtg0795 What are your thoughts? It's been almost two years since this was requested.

NeilGirdhar avatar Feb 11 '24 11:02 NeilGirdhar

@rtg0795 protobuf>=3.20.3,<4.21 is not sufficient because 4.21 is the first released 4.x version.

This is blocking us as well.

jeffpicard avatar Mar 13 '24 15:03 jeffpicard

Thank you for fixing this on master! For everyone watching this, we just need to wait for the next release or use the master version.

Also, just noting that Protobuf 5 is now out :smile:

NeilGirdhar avatar Mar 15 '24 04:03 NeilGirdhar

Is this fixed on master? The boundary is still <4.21, which does not include any valid protobuf 4 versions. This is impacting my organization as well. We have packages that depend on protobuf >4, and the current boundary does not provide that.

Note: This is for Py39/310, the newer protobuf versions are supported for py311, but note even TFX supports 311 yet/we will probably need 39/310 support for a while anyways

rclough avatar Aug 16 '24 16:08 rclough