lingvo

lingvo copied to clipboard

Hi there,

I have a fork of lingvo that has been very useful for my team's work for a while now. I recently noticed that REGISTER_OP("AsciiToTokenId") in x_ops.cc is missing a SetShapeFn() call, which causes problems in my own work. This is presumably easy to add, but I am curious whether there is upstream interest in this. From what I can tell, lingvo is not very actively developed in the open, and is mostly done through Copybara, etc. There's also no CI for github from what I see.

I just wanted to check in advance.

Thank you, Daniel.

Pull requests are completely welcome, see https://github.com/tensorflow/lingvo/blob/master/CONTRIBUTING.md

There is no CI on github but the PR is run through internal CI on our side. The commit will also be made internally and then pushed out again via Copybara, but you will see the commit attributed to you on github.

Thanks for letting me know @jonathanasdf