addons icon indicating copy to clipboard operation
addons copied to clipboard

add CRF tutorial

Open howl-anderson opened this issue 4 years ago • 10 comments

Description

Brief Description of the PR:

add a tutorial for CRF Layer

To Reviewers:

Here is the candidate feature list for this tutorial:

  • [Done] Replace faked training data with real training data:
    • Pros: make the tutorial more practicable
    • Cons: Add many codes for data processing, make it longer and less concentration.
  • [Done] Add additional custom training step base approach (co-exists with current custom training loop based approach):
    • Pros: User have more choose of programming style
    • Cons: Add some (not much) codes, make it longer and less concentration.

What do you think?

Fixes # (issue)

Type of change

Checklist:

  • [ ] I've properly formatted my code according to the guidelines
    • [ ] By running Black + Flake8
    • [ ] By running pre-commit hooks
  • [ ] This PR addresses an already submitted issue for TensorFlow Addons
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] This PR contains modifications to C++ custom-ops

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes: *

howl-anderson avatar Aug 28 '21 06:08 howl-anderson

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Update: I am working on update this tutorial with real training data.

howl-anderson avatar Aug 31 '21 02:08 howl-anderson

Update: all the planed features are implemented. it still needs some polish but it's ready for technical review.

howl-anderson avatar Sep 06 '21 05:09 howl-anderson

When #2555 is merged, I will update this tutorial accrodingly.

howl-anderson avatar Sep 06 '21 05:09 howl-anderson

@howl-anderson Can you join in the official forum?

We have some user looking for CRF support: https://discuss.tensorflow.org/t/how-to-implement-and-use-a-linear-chain-crf-in-tensorflow/4742/

bhack avatar Sep 30 '21 15:09 bhack

@bhack Sure, I will handle this. Thank you!

howl-anderson avatar Sep 30 '21 16:09 howl-anderson

Update: since #2555 is merged, I will update this tutorial soon.

howl-anderson avatar Oct 07 '21 05:10 howl-anderson

Update: The tutorial is ready. Depends on #2591

howl-anderson avatar Oct 18 '21 04:10 howl-anderson

@seanpmorgan Please take a look

howl-anderson avatar Nov 23 '21 08:11 howl-anderson

@MarkDaoust Please take a look

howl-anderson avatar Jan 20 '22 11:01 howl-anderson

Thank you for your contribution. We sincerely apologize for any delay in reviewing, but TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision: TensorFlow Addons Wind Down

Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA: Keras Keras-CV Keras-NLP

seanpmorgan avatar Mar 01 '23 04:03 seanpmorgan