sdk-typescript icon indicating copy to clipboard operation
sdk-typescript copied to clipboard

Published 20 hours ago • verified publisher icon temporalio

[Bug] Comment unclear on when activities are cancelled after calling `Worker.shutdown`

Open bergundy opened this issue 1 year ago • 3 comments

It should mention that the activities are cancelled after shutdownGraceTime.

https://github.com/temporalio/sdk-typescript/blob/28d4de33a2697c949b863d1c541063384c4fcc7c/packages/worker/src/worker.ts#L733

bergundy avatar Dec 05 '23 22:12 bergundy

Can I pick this up? I am new to this repo, let me know where I should start.

gaurava05 avatar Dec 20 '23 10:12 gaurava05

@gaurav7019 sure, thanks—you can submit a PR that edits the comment linked to above

lorensr avatar Dec 22 '23 04:12 lorensr

@lorensr I would like to submit a PR that edits the comment

nikhilbhatia08 avatar Sep 20 '24 16:09 nikhilbhatia08