triggers
triggers copied to clipboard
WIP: Add Namespaced Scope Interceptor
Added Namespaced Scope Interceptor. A namespaced admin can create and manage its interceptor without requiring elevated permissions. Fixes #1364
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
- [x] Includes tests (if functionality changed/added)
- [ ] Includes docs (if user facing)
- [x] Commit messages follow commit message best practices
- [ ] Release notes block has been filled in or deleted (only if no user facing changes)
See the contribution guide for more details.
Release Notes
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/triggers/v1alpha1/namespaced_interceptor_defaults.go | Do not exist | N/A | |
| pkg/apis/triggers/v1alpha1/namespaced_interceptor_types.go | Do not exist | 100.0% | |
| pkg/apis/triggers/v1alpha1/namespaced_interceptor_validation.go | Do not exist | 100.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/triggers/v1alpha1/namespaced_interceptor_defaults.go | Do not exist | N/A | |
| pkg/apis/triggers/v1alpha1/namespaced_interceptor_types.go | Do not exist | 100.0% | |
| pkg/apis/triggers/v1alpha1/namespaced_interceptor_validation.go | Do not exist | 100.0% | |
| pkg/reconciler/namespacedinterceptor/controller.go | Do not exist | 0.0% | |
| pkg/reconciler/namespacedinterceptor/namespacedinterceptor.go | Do not exist | 90.9% |
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/triggers/v1alpha1/namespaced_interceptor_defaults.go | Do not exist | N/A | |
| pkg/apis/triggers/v1alpha1/namespaced_interceptor_types.go | Do not exist | 100.0% | |
| pkg/apis/triggers/v1alpha1/namespaced_interceptor_validation.go | Do not exist | 100.0% | |
| pkg/reconciler/namespacedinterceptor/controller.go | Do not exist | 0.0% | |
| pkg/reconciler/namespacedinterceptor/namespacedinterceptor.go | Do not exist | 90.9% |
/test pull-tekton-triggers-build-tests
/test pull-tekton-triggers-integration-tests
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To complete the pull request process, please ask for approval from khrm after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/triggers/v1alpha1/namespaced_interceptor_defaults.go | Do not exist | N/A | |
| pkg/apis/triggers/v1alpha1/namespaced_interceptor_types.go | Do not exist | 100.0% | |
| pkg/apis/triggers/v1alpha1/namespaced_interceptor_validation.go | Do not exist | 100.0% | |
| pkg/reconciler/namespacedinterceptor/controller.go | Do not exist | 0.0% | |
| pkg/reconciler/namespacedinterceptor/namespacedinterceptor.go | Do not exist | 90.9% |
@khrm: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Opening a new pr with different CRD name.