active_record_replica
active_record_replica copied to clipboard
teespring-labs
Rails 6
Description of changes
Support Rails 6
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@reidmorrison this is awesome. Could you rebase so that I can better understand the diff after merging your other PR to bring us to version 3?
Yes, that would be great, we have been running my fork for several months in production now. We first started on Rails 6.0 and are now running Rails 6.1. The changes above started with running RuboCop to fix syntax and include a major refactor to support Rails 6.x.
The changes above started with running RuboCop to fix syntax and include a major refactor to support Rails 6.x.
would you also include .rubocop.yml file with? I’m wondering what are cops were used.
Lol, good point, I have a .rubocop.yml file in the root path for all my open source projects. I need to add it to not only to this PR but all my own open source projects. :+1:
@goodgravy I see you gave me merge privileges to this repo, do you want me to do a squash merge of the above commits?
This gem can be significantly simplified if we create a new major version that only supports Rails 6 and above, since it can use the Rails built-in multi-database support. I can work on that approach if there is interest? It will also make supporting multiple replicas fairly straight forward to meet @mainameiz's requirements.