bit icon indicating copy to clipboard operation
bit copied to clipboard

Published 20 hours ago • verified publisher icon teambit

copy path util functions from legacy to harmony

Open ocombe opened this issue 3 years ago • 3 comments
trafficstars

ocombe avatar Dec 27 '21 13:12 ocombe

@GiladShoham I copied all the functions from the path file in legacy, although it seems like only normalizePathToLinux is used in all of our components, should I just remove the other functions ?

ocombe avatar Dec 27 '21 15:12 ocombe

I think the other are used in the legacy. And since we are going to remove it from the legacy and replace it with the package we will probably need it

GiladShoham avatar Dec 27 '21 22:12 GiladShoham

@ocombe maybe we should name it something like path/os-compatibility Then export all the types as well? Also, I would remove the getPathRelativeRegardlessCWD from this component. it's not really related. maybe extract it to its own component.

GiladShoham avatar Dec 28 '21 11:12 GiladShoham