jdeb

jdeb copied to clipboard

[WARNING] ***************************************************************** [WARNING] * Your build is requesting parallel execution, but project * [WARNING] * contains the following plugin(s) that have goals not marked * [WARNING] * as @threadSafe to support parallel building. * [WARNING] * While this /may/ work fine, please look for plugin updates * [WARNING] * and/or request plugins be made thread-safe. * [WARNING] * If reporting an issue, report it against the plugin in * [WARNING] * question, not against maven-core * [WARNING] ***************************************************************** [WARNING] The following plugins are not marked @threadSafe in : [WARNING] org.vafer:jdeb:1.0.1:jdeb [WARNING] *****************************************************************

Would that prevent using jdeb with Maven 2 ?

I don't think so since annotations are designed to not prevent the class to work even if you don't have the annotation in your classpath (event if there is not much value in continuing to support Maven 2).

I think we have to fix the thread safety of FilteredFile first, the static fields may conflict if several instances of jdeb are run in parallel.

I agree with https://github.com/tcurdt/jdeb/blob/master/src/main/java/org/vafer/jdeb/maven/DebMojo.java#L262 :)

still room for refactoring - but the statics are gone now.

since we are attaching to the package phase I am wondering if checking whether it's threadsafe is useful at all.

I also think it would be worth updating the maven version - but I fear that could mean quite some work.

Using Maven 3 now, so this should be easier https://github.com/tcurdt/jdeb/commit/45f3e53fc1293a176459e98e4888e09622f3184d