greiner-hormann

greiner-hormann copied to clipboard

I ran into a case where https://github.com/tcql/greiner-hormann/blob/master/lib/union.js#L70 threw an error because unionRings ended up trying to push holes to the (nonexistent) holes parameter.

Also, if I'm understanding this right, could the line above actually result in a recursive case? I.e., you have two holes, but unioning them could result in "holes of holes", which themselves would need to be unioned with the original rings... ugh

... ugh

:point_up: most of my experience trying to figure out how to apply GH to complex geometries.

Do you have a test case that's reproducible so I can test it out?

Ah sorry -- lost the test case because it happened in the middle of a big complicated debugging session late at night... 50% chance I'll hit it again today, and will definitely post it if so

On Fri, Nov 13, 2015 at 9:38 AM Tim Channell [email protected] wrote:

... ugh

[image: :point_up:] most of my experience trying to figure out how to apply GH to complex geometries.

Do you have a test case that's reproducible so I can test it out?

— Reply to this email directly or view it on GitHub https://github.com/tcql/greiner-hormann/issues/19#issuecomment-156447522 .