XkcdViewer

XkcdViewer copied to clipboard

One user requested this in comments.

Seems like you already have code in place to do this (share image). Adding a menu option to call that function shouldn't be too hard.

Yes, it's not much work to implement it. What's been putting me off is what the behaviour should be. Should it ask the user for a location to save it, or should it save to a predictable location (e.g. /sdcard/xkcdViewer/123.png) and use toast to display it? Need to check what other apps do.

I'm not sure I'd blindly follow other apps practices. Most of them like to clutter users sdcards by creating all their new folders on the root instead ofof using appropriate folders that are likely already there.

For behavior, I suggest adding a preference to your settings activity that allows the user to set the location to save images, and have a default value of /sdcard/Pictures.

http://developer.android.com/guide/topics/data/data-storage.html#filesExternal The above link contains suggested file storage practices, and though I'm sure youve already seen it, I figured I'd point it out since most apps ignore these practices and place their caches and export directories directly on the sdcard root.

Like the viewer. Would love to have things cached for offline reading. Hope you can support mouseover comments in the offline version too.

The reasonable default would probably be /sdcard/Pictures/xkcd or possibly /sdcard/Pictures/Comics/xkcd

@horkana just in case you weren't aware, you can get the mouseover text by clicking on the image itself. I have a touchscreen so having it on hover obviously doesn't work on my phone -- not sure if there are other devices where it would make sense.

Saw from the documentation that mouseover text was supported and after a while guessed that I just needed to click to support it. I'm not sure how else you might have implemented it but my first guess was that you might just show the text beneath the image but click to show works fine. I suppose maybe some kind of on screen overlay might make it a little more discoverable but as I said I guessed soon enough. (My tiny screen makes me concerned about the accessibility of presenting text as an image is a whole other issue the downside of the simple image formats used for most comics but unless Randall Munroe decides to present the text in an accessible way that is far beyond the scope of what I'd expect.)

It's kind of disappointing to see that this viewer would the best, save for that missing feature... I found the in-app downloads in the app from Alex Avance (which I'm using) to be the most convenient. The comic is saved offline, accessed in-app from the catalogue and viewed just like the ones still online.

Sorry, I haven't been giving this project the attention it deserves. I have more commitments now than I did 3 years ago, and it's hard to find the time to work on this.

I'll still be fixing bugs and accepting pull requests, but I don't plan to implement any new features myself. If you find Alex Avance's app to work better for your needs then by all means go ahead and use it. :)