markdown-link-check
markdown-link-check copied to clipboard
Unexpected pre-commit behavior with v3.13.7
Given the following two files in a git repo:
$ cat .pre-commit-config.yaml
repos:
- repo: https://github.com/tcort/markdown-link-check
rev: v3.13.7
hooks:
- id: markdown-link-check
$ cat README.md
[bad link](does-not-exist.com)
The bad link is not caught by the current version:
$ pre-commit run --all-files markdown-link-check
Markdown Link Check......................................................Passed
If I change .pre-commit-config.yaml to use 3.12.2:
$ pre-commit run --all-files markdown-link-check
Markdown Link Check......................................................Failed
- hook id: markdown-link-check
- exit code: 1
(node:34512) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
FILE: README.md
[✖] does-not-exist.com
1 links checked.
ERROR: 1 dead links found!
[✖] does-not-exist.com → Status: 400
I am using the following version of pre-commit in both cases:
$ pre-commit --version
pre-commit 4.0.1