Ondra Kupka

Results 47 comments of Ondra Kupka

In other words, using `return c.Core.Check(ent, ce)` in `Check` fixes the issue, but that is not what you want, you want to register the wrapping core, right?

What obviously works is to add ```golang func Wrap(c zapcore.Core) zapcore.Core { return &core{c, newLabels(), newLabels()} } ``` and do ```golang core := zapcore.NewTee( zapdriver.Wrap(zapcore.NewCore(consoleEncoder, os.Stderr, zapcore.ErrorLevel)), zapdriver.Wrap(zapcore.NewCore(consoleEncoder, os.Stdout, zapcore.InfoLevel)),...

Ok, can be done already ```golang core := zapcore.NewTee( zap.New(zapcore.NewCore(consoleEncoder, os.Stderr, zapcore.ErrorLevel)). WithOptions(zapdriver.WrapCore()).Core(), zap.New(zapcore.NewCore(consoleEncoder, os.Stdout, zapcore.InfoLevel)). WithOptions(zapdriver.WrapCore()).Core(), ) ``` Still wondering whether the library can be fixed so that the...

Sorry, didn't notice this before, dunno how that could have happened.

Looks like you changed quite a bit. You think it would be possible to rebase onto master.

I am pretty busy with my day to day job these days, so I am not sure I will get to this any time very soon. Perhaps this weekend, if...