Tanner Linsley

Results 196 comments of Tanner Linsley

Are they slow renders? Renders are not bad, but slow renders are. Profile if you can and post your findings. 👍 On Feb 3, 2020, 2:03 PM -0700, Andrii Polishchuk...

@afshinm Just confirming that this is still an issue. I'm using the angular-intro port, but the issue resides with the positioning/z-indexing. Any ideas on this?

@afshinm In my particular situation, changed the parent z-index to match that of the highlighted element (99999...) worked perfectly. But I agree that in the other scenarios above, there is...

@Dozyatom I think using your surround method could be promising in an intro.js context. I would be interested in seeing that.

@Dozyatom Have you tried integrating the surround method into intro.js though? I am looking into your code right now and seeing how difficult it would be to replace Intro.js's overlay...

@Dozyatom So, I just submitted a pull request to guide.js with some tiny things, and also just created "angular-guide" which is a port of the angular-intro wrapper but for guide.js...

I’ll need you to replicate this in a code sandbox or online repl so I can debug it.

Are any of your router components perhaps using React.memo or using useMemo to memoize returned JSX?

Very strange. As per usual, a CodeSandBox that exhibits the issue will help me fix this 100x faster and easier

All should be fixed in the new "Router".