create-t3-app icon indicating copy to clipboard operation
create-t3-app copied to clipboard

docs: made themeToggleButton a toggle button

Open muradbu opened this issue 3 years ago • 3 comments

Closes #781

✅ Checklist

  • [x] I have followed every step in the contributing guide (updated 2022-10-06).
  • [x] The PR title follows the convention we established conventional-commit
  • [ ] I performed a functional test on my final commit

Changelog

Refactored themeToggleButton to use a <button> root element instead of 2 radio buttons so that the light/dark theme gets toggled regardless of where the user presses within the component.

The component's title, value and aria-label attributes gets set on page-load using the appropriate dark/light state.


Screenshots

theme toggle 3

💯

muradbu avatar Nov 18 '22 13:11 muradbu

⚠️ No Changeset found

Latest commit: 468609b19cbfc5b9420f6c75c77420af0d2733c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Nov 18 '22 13:11 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Nov 18, 2022 at 11:58PM (UTC)

vercel[bot] avatar Nov 18 '22 13:11 vercel[bot]

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-fork-muradbuyukasik-next-t3-oss.vercel.app/

github-actions[bot] avatar Nov 18 '22 13:11 github-actions[bot]