simple-signal icon indicating copy to clipboard operation
simple-signal copied to clipboard

ERR_DATA_CHANNEL error will be throw by SimplePeer and application level code cannot catch it.

Open milochen0418 opened this issue 5 years ago • 1 comments

The SimpleSignalClient code will receive error randomly if another peer's website page refresh .

After checking this problem, we cannot catch this error.

Right now we can avoid this issue it by this way

Screen Shot 2021-01-25 at 10 07 13 PM

Because we cannot catch this error, so I try to avoid to throw it when ERR_DATA_CHANNEL error happen.

So we can at least implement dynamically peer remove/add in the room.

milochen0418 avatar Jan 25 '21 14:01 milochen0418

The RTCErrorEvent will be throw as err in events/events.js if we don't handle peer('error'). So I put it in client code.

 
peer.on('error', (err)=>{
  console.log(err)
})

This is issue is solve by this pull request https://github.com/t-mullen/simple-signal/pull/36

milochen0418 avatar Jan 26 '21 05:01 milochen0418