bitkit
bitkit copied to clipboard
[Bug]: Duplicated activities
Describe the bug
I restored a wallet that had an open Lightning channel and I couldn't restore due to the same issue at #1130. Now, many of my activities are duplicated.
Reproduce
- Go to '...'
- Click on '....'
- Scroll down to '....'
- See error
Screenshots / Recording
https://github.com/synonymdev/bitkit/assets/93796166/9b96d9e6-fd7b-4b11-9548-03626ba55473
Operating system
iOS 17
Bitkit version
64
Log output
No response
@limpbrains Do you think this issue is also fixed by https://github.com/synonymdev/bitkit/pull/1271?
Yes
@limpbrains, it looks like there was a regression here, this just happened following a CJIT open:
https://github.com/synonymdev/bitkit/assets/93796166/87e5c13d-cb4c-4ec1-8a71-cababbcd7b5d
Pav, Ivan and I can't reproduce this issue on v94
Things have gone crazy over here:
https://github.com/synonymdev/bitkit/assets/93796166/c61148d3-b86f-47af-9ecb-b7c4a5b23cb9
@mattcrv can you test it again with v98? Jay should I fixed it but I prefer to test it to be sure as you had this issue.
@mattcrv can you test it again with v98? Jay should I fixed it but I prefer to test it to be sure as you had this issue.
Just tested on 99. Not sure if expected, but those payments received three weeks ago via CJIT are still duplicated on my activities list. I didn't have more duplicated activities since then.
https://github.com/synonymdev/bitkit/assets/93796166/1280bea9-a605-4da1-9cf8-c96d3b3e2b91
@pwltr can you have a look about this issue?
It sounds like the issue is fixed on the latest release? If so the task is to find a way to clean up old duplicated transactions which I'm not sure is worth the effort seeing this issue has only been reported once. I'd suggest we revisit this if it happens again.
Tested few times already but couldn't reproduce it.
Looks like this doesn't happen anymore. Closing for now.