bitkit icon indicating copy to clipboard operation
bitkit copied to clipboard

[Bug]: Duplicated activities

Open mattcrv opened this issue 2 years ago • 10 comments

Describe the bug

I restored a wallet that had an open Lightning channel and I couldn't restore due to the same issue at #1130. Now, many of my activities are duplicated.

Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots / Recording

https://github.com/synonymdev/bitkit/assets/93796166/9b96d9e6-fd7b-4b11-9548-03626ba55473

Operating system

iOS 17

Bitkit version

64

Log output

No response

mattcrv avatar Sep 07 '23 19:09 mattcrv

@limpbrains Do you think this issue is also fixed by https://github.com/synonymdev/bitkit/pull/1271?

pwltr avatar Sep 27 '23 15:09 pwltr

Yes

limpbrains avatar Sep 27 '23 15:09 limpbrains

@limpbrains, it looks like there was a regression here, this just happened following a CJIT open:

https://github.com/synonymdev/bitkit/assets/93796166/87e5c13d-cb4c-4ec1-8a71-cababbcd7b5d

mattcrv avatar Jan 12 '24 00:01 mattcrv

Pav, Ivan and I can't reproduce this issue on v94

JeanlChristophe avatar Jan 12 '24 11:01 JeanlChristophe

Things have gone crazy over here:

https://github.com/synonymdev/bitkit/assets/93796166/c61148d3-b86f-47af-9ecb-b7c4a5b23cb9

mattcrv avatar Jan 12 '24 13:01 mattcrv

@mattcrv can you test it again with v98? Jay should I fixed it but I prefer to test it to be sure as you had this issue.

JeanlChristophe avatar Jan 29 '24 14:01 JeanlChristophe

@mattcrv can you test it again with v98? Jay should I fixed it but I prefer to test it to be sure as you had this issue.

Just tested on 99. Not sure if expected, but those payments received three weeks ago via CJIT are still duplicated on my activities list. I didn't have more duplicated activities since then.

https://github.com/synonymdev/bitkit/assets/93796166/1280bea9-a605-4da1-9cf8-c96d3b3e2b91

mattcrv avatar Jan 29 '24 14:01 mattcrv

@pwltr can you have a look about this issue?

JeanlChristophe avatar Jan 29 '24 14:01 JeanlChristophe

It sounds like the issue is fixed on the latest release? If so the task is to find a way to clean up old duplicated transactions which I'm not sure is worth the effort seeing this issue has only been reported once. I'd suggest we revisit this if it happens again.

pwltr avatar Jan 30 '24 12:01 pwltr

Tested few times already but couldn't reproduce it.

JeanlChristophe avatar Jan 30 '24 14:01 JeanlChristophe

Looks like this doesn't happen anymore. Closing for now.

pwltr avatar Apr 24 '24 11:04 pwltr