syncthing-android icon indicating copy to clipboard operation
syncthing-android copied to clipboard

Published 20 hours ago • verified publisher icon syncthing

Various config elements lost on config change through wrapper UI

Open Catfriend1 opened this issue 6 years ago • 2 comments

Description of the issue

Introducer's Device ID get's lost if any syncthing core settings are changed through the wrapper's UI.

Reproducer

  • Setup an introducer device and mark it as introducer on the android.
  • Share a folder with the introducer device and a third device.
  • Mark the introducer device as introducer on the third device.
  • The third device gets "introduced" and thus added to the android.
  • Change any syncthing "config.xml" related setting through the wrapper's UI.
  • BAM - You'll lose the introducedBy="[device_id"] in config.xml.

Version Information

App Version: <= 0.10.15 (most recent version)

Catfriend1 avatar Dec 21 '18 12:12 Catfriend1

I just noticed that the android app doesn't remove peers when the introducer removes them, seems this is likely why.

edrex avatar Sep 13 '19 21:09 edrex

The problem is that the representation of the config as java classes is outdated and any change causes the entire config to be posted to the API. Ideally the latter is changed to do finegrained changes with the new /rest/config/... endpoints and PATCH method (and of course classes updated where necessary).

imsodin avatar Dec 19 '21 17:12 imsodin