symfony-docs icon indicating copy to clipboard operation
symfony-docs copied to clipboard
verified publisher icon symfony

Ensure config blocks are consistent #2

Open HeahDude opened this issue 3 years ago • 1 comments

Continuation of #16992.

HeahDude avatar Aug 11 '22 06:08 HeahDude

I need to check and fix some reported errors.

Status: needs work

HeahDude avatar Aug 11 '22 14:08 HeahDude

@HeahDude do you still consider this as "needs work" or is it ready? Thanks!

javiereguiluz avatar Oct 05 '22 14:10 javiereguiluz

Yes, sadly it still needs work, and I need help, I'll see if I can get some next week at the Forum PHP when meeting old friends :).

HeahDude avatar Oct 05 '22 16:10 HeahDude

Thanks for the review @wouterj :), I'll work on it later this week.

HeahDude avatar Oct 10 '22 14:10 HeahDude

Symfony 4.4 is no longer supported ... so we should rebase this PR to 5.4 or higher. Thanks!

javiereguiluz avatar Dec 01 '22 16:12 javiereguiluz

It's sad to see that this PR stalled. @HeahDude would you have the time and energy needed to rebase it? If you don't, we totally understand it. Thanks!

javiereguiluz avatar Jun 15 '23 13:06 javiereguiluz

@javiereguiluz Yes, thanks for the ping :)

HeahDude avatar Jun 15 '23 14:06 HeahDude

Again, asking friendly to retarget on 5.4 😍

Thanks!

OskarStark avatar Aug 14 '23 07:08 OskarStark

I'm afraid we'll have to close this. If you ever find time to continue this great (in both definitions of the word) contribution, we can always reopen it.

wouterj avatar Feb 19 '24 22:02 wouterj