Type-on-Strap

Type-on-Strap copied to clipboard

Is your feature request related to a problem? Please describe.

The current implementation(screenshot below) can be improved in terms of accessibility.

Describe the solution you'd like

like this.

My current implementation is something like this:

{% for page in site.pages %}
    {% unless page.title == null or page.hide or name_page contains page.title %}
    <li class="separator"> | </li>
    <li>
        <a class="clear" aria-label="{{ page.title }}" title="{{ page.title }}" href="{{ page.url | relative_url }}">
            {% if page.icon %} <i class="fas {{ page.icon }}" aria-hidden="true"></i>{% endif%}
            <span class="menu-label {%if page.icon %}menu-label-with-icon{% endif%}">{{ page.title }}</span>
        </a>
    </li>
    {% endunless %}
    {% assign name_page = page.title | append: name_page %}
{% endfor %}

This is a breaking change, but I can send a PR if you like this proposal.

Describe alternatives you've considered

Align icon-only links in a single row?

Additional context Add any other context or screenshots about the feature request here.

Hi thanks!

I was thinking about it, but did not take the time to implement it. I could take a look at your implementation and see where we can go from there.

Closing this one as it will be done in #394