semver icon indicating copy to clipboard operation
semver copied to clipboard

Convert to multiplatform project

Open NorbertSandor opened this issue 6 years ago • 5 comments

Works as a multiplatform implementation with trivial modifications ;)

NorbertSandor avatar Aug 26 '19 19:08 NorbertSandor

Have you already done it? Otherwise I'd give it a shot. I do need that at the moment :)

felixbaral avatar Nov 10 '21 13:11 felixbaral

Sorry, no. (At least not in a "nice" way...)

NorbertSandor avatar Nov 10 '21 13:11 NorbertSandor

@felixbaral Hello! I am working on this now and also do a rewrite as well.

ericksli avatar Nov 25 '21 15:11 ericksli

Nice to hear. I did a minimal solution. It works for me, but I ignored dokka and i only tested it on android and ios.

but maybe it is useful https://github.com/HVN11/semver

felixbaral avatar Nov 26 '21 11:11 felixbaral

@felixbaral I revised the implementation and converted the whole project into a Kotlin mulitplatform project (in multiplatform branch). However, I found that running unit tests on NodeJS failed perhaps due to the regular expression "or" bug in Kotlin/JS

ericksli avatar Dec 08 '21 04:12 ericksli

Maybe any news on this one?

NorbertSandor avatar Jul 18 '23 15:07 NorbertSandor

However, I found that running unit tests on NodeJS failed perhaps due to the regular expression "or" bug in Kotlin/JS

Maybe an expect declaration and platform-specific actual implementations should be used as a workaround, because those regex-related issues do not seem to be fixed ever :(

NorbertSandor avatar Jul 18 '23 15:07 NorbertSandor

@NorbertSandor you may take a look on multiplatform branch and I have already adoped this approach.

However, I still need some time to migrate the CI to GitHub Actions.

https://github.com/swiftzer/semver/tree/multiplatform

ericksli avatar Jul 23 '23 07:07 ericksli

Right now the code in multiplatform branch is migrated to Kotlin multiplatform and right now the missing part is the GitHub Actions part

ericksli avatar Aug 08 '23 14:08 ericksli

@NorbertSandor @felixbaral Please give a try on the latest version 2.0.0, thanks

ericksli avatar Mar 02 '24 15:03 ericksli

I tested the 2.0.0 and it works nicely on my ios and android projects

felixbaral avatar Mar 22 '24 10:03 felixbaral