vsts-mirror-git-repository icon indicating copy to clipboard operation
vsts-mirror-git-repository copied to clipboard

Published 20 hours ago • verified publisher icon swellaby

Review required CI checks for PRs

Open calebcartwright opened this issue 5 years ago • 0 comments

We've currently got an array of PR checks that are required/gates for merging to master, including one for running Sonar scans.

However, our current config also disallows the execution of the Sonar scan on checks for PRs coming from forks (config on the Azure Pipelines side).

The end result is that PRs coming from forks will always have a failed check, so this needs to be changed. Few options I see:

  • Update the config to allow running the Sonar scan, even coming from a fork
  • Disable the Sonar scan job for forks (this may require updating the branch protection policies for master too)
  • Disable the Sonar scan as a PR check altogether and only run it in the CI job post-merge (I'm against this one philosophically FWIW)

calebcartwright avatar Feb 12 '20 02:02 calebcartwright