sway icon indicating copy to clipboard operation
sway copied to clipboard

seat: Fix reloading cursor theme after change

Open nemuibanila opened this issue 3 years ago • 1 comments

This reverts commit afde6369 "seat: avoid unneeded reloading xcursor theme". Always avoiding to reload the xcursor theme prevents reloading the cursor even when this is desired. Instead seat_configure_xcursor can determine whether a full reload is necessary.

To stay with the spirit of the reverted change, cursors are only fully reloaded, if the theme has changed.

Fixes #6931

nemuibanila avatar Jun 13 '22 09:06 nemuibanila

Thanks for fixing this, I ran into this while testing that functionality.

MayeulC avatar Jun 15 '22 21:06 MayeulC

Sorry for the bump but is there anything holding this from being merged? I am also being negatively affected by #6931 and would like to see it resolved.

The failed job seems to be due to an unchanged and unrelated file (ipc-json.c).

MithicSpirit avatar Jun 03 '23 04:06 MithicSpirit

I'm interested in this fix to be able to change the cursor in relation to prefers-color-scheme. If prefer-dark then my cursor will be light, if prefer-light, then my cursor will be dark.

@nemuibanila Gentle ping, this fix will allow me to accomplish this behavior, do you have any news? thanks :)

GreyXor avatar Sep 26 '23 08:09 GreyXor

@emersion Hello, do we miss something here for a review ? I've been on this branch for 1 month without realizing it, everything is ok from a functional point of view. Thanks!

GreyXor avatar Nov 06 '23 12:11 GreyXor