swagger-core

swagger-core copied to clipboard

An attempt to properly map byte[] to the ByteArraySchema or BinarySchema depending on the format specified (if any). The idea here is to introduce the support in PrimitiveType of types which could be mapped to multiple schemas, depending on the format, with the first one being the default in case format is omitted. Closes https://github.com/swagger-api/swagger-core/issues/3944 and https://github.com/swagger-api/swagger-core/issues/3511.

Specification snippets generated:

        bytes:
          type: string
          format: byte

        binary:
          type: string
          format: binary

@webron would really appreciate the feedback if this change make sense, test cases are include, thanks a lot.

My apologies @webron , any interest or feedback on this pull request would be much appreciated, thank you :-)

@reta, I created a pull request for your branch to add support for base64 encoded string examples for byte and binary format. Please, consider including it. Thanks.

thanks @martin-tarjanyi , included, hopefully we could get some attention from the team

@frantuma @HugoMario guys, mind please taking a look? thank you!

@HugoMario @frantuma hey guys, any chance someone could look at it? thank you!

hey @reta , sure. I'll take a time this week to check your PR

hey @HugoMario , any chances to have a pair of eyes on it? :-) Thank you!

@HugoMario did you have a chance to look at this PR yet?

Hey @reta Is the jetty version update related to changs in byte array? BTW, PR looks good to me. I'll sync up again with my team to check this again.

Sorry for so much delay

Hey @HugoMario !

Hey @reta Is the jetty version update related to changs in byte array?

No, it shouldn't be (AFAIK)

BTW, PR looks good to me. I'll sync up again with my team to check this again.

Thanks a mill, really appreciate it!