svix-webhooks icon indicating copy to clipboard operation
svix-webhooks copied to clipboard
verified publisher icon svix

Support PATCH in addition to PUT on all entities

Open adimyth opened this issue 3 years ago • 2 comments

Bug Report

Version

latest as per dockerhub; most likely `v0.63

Platform

docker

Description

Suggest using PATCH instead of PUT in all the apis where we perform an update operation. It is inconvenient to pass in all the data, just to update a couple of fields. This has side-effects & can cause issues elsewhere

Example - I created an endpoint & later wished to update the URL. Using PUT caused all the other data fields like events, etc to be set to NULL.

adimyth avatar Jul 23 '22 12:07 adimyth

I agree, we've been deferring doing this for a while, I'll see if we can get to it soon.

tasn avatar Jul 23 '22 13:07 tasn

@svix-daniel, is this one done? (other than libs)

tasn avatar Aug 15 '22 14:08 tasn

I'm pretty sure it's done (other than the libs which are tracked in #608) so closing this.

tasn avatar Jan 23 '23 22:01 tasn